Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global failures can be filtered out by test-limiting URL parameters #288

Closed
gibson042 opened this issue Jul 20, 2012 · 0 comments
Closed

Global failures can be filtered out by test-limiting URL parameters #288

gibson042 opened this issue Jul 20, 2012 · 0 comments

Comments

@gibson042
Copy link
Member

window.onerror calls QUnit.test to display context-free global errors. QUnit.test no-ops unless the new test passes validTest, which checks against URL parameters like module and testNumber.

This structure can result in global errors being hidden when specific modules or tests were requested, which is rare but possible. Global errors should always be considered valid for display.
gibson042 added a commit to gibson042/qunit that referenced this issue Aug 2, 2012
@gibson042
onerror: force display of global errors despite URL parameters. Fixes q…
285a4af 
…unitjs#288 - Global failures can be filtered out by test-limiting URL parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzaefferer @gibson042