Core: Implement only/skip and todo for modules #1168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Arkni
force-pushed
the
module-only-skip-todo
branch
from
f81195c
to
c6932b4
Compare
Arkni
changed the title
|
I've rebased this and it is now ready for review. |
trentmwillis
requested changes
May 21, 2017
| config.currentModule = module; | ||
| } | ||
|
|
||
| function module( name, testEnvironment, executeNow ) { |
There was a problem hiding this comment.
Can you add a TODO comment here noting that we should extract this to a new file? (I think it'll require some refactoring, so I don't want it to be in this PR).
| suiteReport: new SuiteReport( name, parentSuite ) | ||
| suiteReport: new SuiteReport( name, parentSuite ), | ||
|
|
||
| // Pass along `skip` and `todo` properties from patent module, in case there |
| return; | ||
| } | ||
|
|
||
| moduleStack.length = 0; |
There was a problem hiding this comment.
I don't think we should do this. If you focus a module that is nested within another, then the moduleStack would still need to be used.
|
No worries! I will try to split this PR & address the above comments as soon as possible. Thanks! |
Arkni
added a commit
to Arkni/qunit
that referenced
this pull request
Jun 15, 2018
As requested in qunitjs#1168 (comment)
Arkni
added a commit
to Arkni/qunit
that referenced
this pull request
Jun 15, 2018
As requested in qunitjs#1168 (comment)
trentmwillis
pushed a commit
that referenced
this pull request
Jun 20, 2018
As requested in #1168 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress to implementQUnit.module.{only, skip, todo}.I still need to add some tests and make sure everything is working as expected.
Suggestions are more than welcome.
/Cc @trentmwillis