Tests: Add tests covering callback failures #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture the status quo before changing it. Minor changes: * Switch remaining notEquals/indexOf uses to the preferred `assert.true( str.includes() )` idiom. * Fix duplicate printing of error message due to V8's `Error#stack`, as used by onUncaughtException. Ref qunitjs#1629. * Start normalizing stderror in tests like we do with stdout. * Account for qunit.js stack frames from native Promise in V8, which doesn't include a function name or paranthesis. Ref qunitjs#1446. Ref qunitjs#1633.
Krinkle
force-pushed
the
test-bad-callbacks
branch
from
8d4d0bf
to
656414a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Capture the status quo before changing it.
Minor changes:
Switch remaining notEquals/indexOf uses to the preferred
assert.true( str.includes() )idiom.Fix duplicate printing of error message due to V8's
Error#stack, as used by onUncaughtException.Ref Core: Fix late onerror handling #1629.
Start normalizing stderror in tests like we do with stdout.
Account for qunit.js stack frames from native Promise in V8, which doesn't include a function name or paranthesis.
Ref #1446.
Ref #1633.