Core: Fix bad module nesting when module closure throws global error #1644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krinkle
commented
Aug 2, 2021
| // we teardown internal state to ensure correct module nesting. | ||
| // Ref https://github.com/qunitjs/qunit/issues/1478. | ||
| moduleStack.pop(); | ||
| config.currentModule = module.parentModule || prevModule; |
There was a problem hiding this comment.
Same as before, we only restore currentModule if the module in question is a scoped module. If it is a linear module, then we assign current and leave it as-is. I hope the new structure makes this more obvious. In the old code, this was done a bit strangely.
This asserts the undesirable status quo, where the stack is left in a bad state if the module closure encounters a global error while test suites are still being loaded. Ref qunitjs#1478.
Krinkle
force-pushed
the
fix-module-state
branch
from
4fea2c1
to
478f039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1478.