Build: Specify valid components for commit messages #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would not add License, but I'd probably alphabetize the list. |
- Component invalid, was '[fix]', must be one of these: Assert, Build, CSS, Core, Dump, HTML Reporter, Test, TestsI guess I should implement jzaefferer/commitplease#26 to allow the "fixup!" prefix. |
|
Just be aware that |
|
Yeah, and we should make use of that. |
jzaefferer
force-pushed
the
commitplease-components
branch
from
75720c9
to
980578e
Compare
|
Rebased. @leobalter @JamesMGreene any input on this? Does the list look good to you? |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the update to commitplease 1.11.0 via 5ed001d, we can now specify valid components. Am I missing something? Got something wrong?
I think in the meeting on Wednesday there was a preference of "Reporter" over "HTML Reporter". While we currently have just the one, having a separate folder for reporters justifies a specific component as well. Yay? Nay?
Should we add "License", as used in #526? Or can we dump that into "Build"?