Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase field names in Vorbis comments (again) #152

Closed
lazka opened this issue Jul 4, 2014 · 12 comments
Closed

Lowercase field names in Vorbis comments (again) #152

lazka opened this issue Jul 4, 2014 · 12 comments
Labels

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From mats.pet...@gmail.com on May 29, 2013 10:04:29

I know this issue has been discussed before. Field names in Vorbis comments shouldn't be *stored* in lowercase. I don't care what happens to them inside Mutagen. Converting to lowercase is fine with me. But the standard way is to use uppercase for the field names *in the file*.

Original issue: http://code.google.com/p/mutagen/issues/detail?id=152


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on September 03, 2013 11:43:29

Field names are case insensitive so it doesn't matter how they are stored.

referring to https://code.google.com/p/mutagen/issues/detail?id=51#c9 : mutagen will only store lower case keys if you tell it to or use the dict interface. I've now changed the VCommentDict interface to preserve case information for added keys internally in revision c487b12456a8 .

hth

Status: WontFix

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on May 29, 2013 03:24:01

OK, this is not crucial, it's just that I'm used to field names being in upper case in the files.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 06, 2013 03:13:19

It matters to me how they are stored. I edit the tags with a text editor.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on September 06, 2013 03:53:38

I get that you don't like lowercase keys. The question here is what has that to do with mutagen? Please be more specific.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 06, 2013 03:17:20

Furthermore, it's the unsung "standard" to keep tag names uppercase. But if
you want to do it your own way I can't stop you.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 06, 2013 04:56:44

This is of course a purely cosmetical issue, but I and most other people are used to seeing uppercase field names in the vorbis comments.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 06, 2013 04:50:17

Make it store the field names in uppercase in the files. That's all. Once again, this is only concerning the case of the field names in the FILES. What happens inside Mutagen is up to you to decide.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From reiter.christoph@gmail.com on September 06, 2013 09:58:34

Again: It stores field names upper case if you tell it to. Like your text edit will if you tell it to.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 07, 2013 02:53:23

I'm done with this. Do whatever you want.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 07, 2013 02:51:52

The conversion to lowercase is hardcoded in Mutagen as far as I can see. I
don't see where the text editor fits in here. It's just a text editor,
nothing else.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 07, 2013 03:08:54

Change all these calls from lower() to upper() and you're done.
@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From mats.pet...@gmail.com on September 07, 2013 03:05:24

On a final note. _vorbis.py contains unconditional lower() calls all over
the place. That's hardly user configurable in my book at least.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.