Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear what the build system is #581

Closed
mgorny opened this issue Oct 26, 2022 · 5 comments
Closed

Unclear what the build system is #581

mgorny opened this issue Oct 26, 2022 · 5 comments

Comments

@mgorny
Copy link
Contributor

mgorny commented Oct 26, 2022

What is the actual build system used by mutagen?

pyproject.toml has some poetry metadata but the build-system section includes setuptools requirements. However, even then it doesn't declare any build-backend, neither setuptools' nor poetry's.

@lazka
Copy link
Member

lazka commented Oct 26, 2022

https://peps.python.org/pep-0517/

If the pyproject.toml file is absent, or the build-backend key is missing, the source tree is not using this specification, and tools should revert to the legacy behaviour of running setup.py (either directly, or by implicitly invoking the setuptools.build_meta:legacy backend).

Is this causing any problems (both "build" and "pip" seem to do the right thing) ? I can make it explicit if needed

lazka added a commit to lazka/mutagen that referenced this issue Oct 26, 2022
It defaulted to setuptools.build_meta.__legacy__.
Set explicitely to avoid any confusion.

See quodlibet#581
@lazka
Copy link
Member

lazka commented Oct 26, 2022

See #582.

I'd still like to know if this is causing any problems and requires a new release.

@mgorny
Copy link
Contributor Author

mgorny commented Oct 26, 2022

No, no real problems right now. Just a bit confusion, and if you don't specify the setuptools backend explicitly, then you're relying on (somewhat obsolete) legacy setuptools backend. No need to make a new release over this.

@lazka
Copy link
Member

lazka commented Oct 26, 2022

OK, thanks. I've merged #582

@lazka lazka closed this as completed Oct 26, 2022
@lazka
Copy link
Member

lazka commented Oct 26, 2022

(as for the poetry/setuptools mix.. it allows me to use poetry for dev, while still providing a setup.py with some minimal metadata duplication)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants