Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mid3iconv: isascii broken #75

Closed
lazka opened this issue Jul 4, 2014 · 2 comments
Closed

mid3iconv: isascii broken #75

lazka opened this issue Jul 4, 2014 · 2 comments
Labels
bug

Comments

@lazka
Copy link
Member

@lazka lazka commented Jul 4, 2014

Originally reported by: Christoph Reiter (Bitbucket: lazka, GitHub: lazka)


From Anton.Bu...@gmail.com on October 31, 2010 12:37:12

Should be '\x7f', not '\x127'

>>> def isascii(string):return not string or min(string) < '\x127'
... 
>>> isascii('f')
False
>>> 
>>> def isascii(string):return not string or min(string) < '\x7f'
... 
>>> isascii('f')
True
>>>

Original issue: http://code.google.com/p/mutagen/issues/detail?id=75


@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on October 31, 2010 04:53:53

Actually, no, it's even more wrong than that.

Summary: mid3iconv: isascii broken
Status: Accepted
Labels: -Type-Enhancement Type-Defect

@lazka

This comment has been minimized.

Copy link
Member Author

@lazka lazka commented Jul 4, 2014

Original comment by Christoph Reiter (Bitbucket: lazka, GitHub: lazka):


From joe.wreschnig@gmail.com on October 31, 2010 04:58:45

This issue was closed by revision r98 .

Status: Fixed

@lazka lazka added trivial bug labels Apr 7, 2016
@lazka lazka closed this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.