Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RIFF/WAVE support, using ID3v2 #321

Closed
wants to merge 37 commits into from
Closed

RIFF/WAVE support, using ID3v2 #321

wants to merge 37 commits into from

Commits on Oct 15, 2019

  1. Initial support for RIFF/WAVE format, using ID3v2 tags 

    Related to issue quodlibet#207
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    f69a539 View commit details
    Browse the repository at this point in the history

  2. quodlibet#207: Add WAVE file type

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    bc6a9a7 View commit details
    Browse the repository at this point in the history

  3. quodlibet#207: fix indentation

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    404d55c View commit details
    Browse the repository at this point in the history

  4. quodlibet#207: fix blank line

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9d65f6f View commit details
    Browse the repository at this point in the history

  5. Fix import statement quodlibet#207

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    793db3c View commit details
    Browse the repository at this point in the history

  6. quodlibet#207: respect E501 max line length of 79

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    a36c3a6 View commit details
    Browse the repository at this point in the history

  7. quodlibet#207: Normalize ID3v2 chunk to lowercase 'id3 ' chunk

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    1f1f72b View commit details
    Browse the repository at this point in the history

  8. Comply with 79 max-line-length

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    0a1ea1c View commit details
    Browse the repository at this point in the history

  9. quodlibet#207: changed access scope of __fileobj from private to prot… 

    …ected
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    95ba3a8 View commit details
    Browse the repository at this point in the history

  10. Put assert isinstance(id_, text_type) in every function

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    bac3bcb View commit details
    Browse the repository at this point in the history

  11. quodlibet#207: disable chunk-id text assertion

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    cd2446b View commit details
    Browse the repository at this point in the history

  12. Remove text_type from import

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    4190246 View commit details
    Browse the repository at this point in the history

  13. Improve code quality. 

    Remove duplicate code between wave.py and _riff.py
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9877083 View commit details
    Browse the repository at this point in the history

  14. Check all of the 4 characters of the FOURCC

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    81d0de0 View commit details
    Browse the repository at this point in the history

  15. Add generic FileType tests

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    449ef0d View commit details
    Browse the repository at this point in the history

  16. Remove py3 code

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    392cb98 View commit details
    Browse the repository at this point in the history

  17. Fix missing space in RIFF ID3-chunk-ID

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    2f1e005 View commit details
    Browse the repository at this point in the history

  18. KeyError => ValueError 

    Ref:
- quodlibet#321 (comment)
- a5c3785ed8d6a35868bc169f07e40e889087fd2e
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    e8e73c5 View commit details
    Browse the repository at this point in the history

  19. Fix code style issues

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    0e904f4 View commit details
    Browse the repository at this point in the history

  20. Try to fix: isinstance(id, text_type) return false on chunk-id which … 

    …should be a text type
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    8b097ac View commit details
    Browse the repository at this point in the history

  21. Remove unused import

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    21552ef View commit details
    Browse the repository at this point in the history

  22. Fix lint errors

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    26d7670 View commit details
    Browse the repository at this point in the history

  23. Restore test file to include all tests

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    22a9a05 View commit details
    Browse the repository at this point in the history

  24. Fix unit tests loading RIFF/WAVE by throwing MutagenError instead of 

    ValueError.
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    62f7eb0 View commit details
    Browse the repository at this point in the history

  25. Fix function RiffFile.insert_chunk: 

    * fix wrong abstract attribute reference
* fix reference to root ('RIFF') chuck
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    1be502a View commit details
    Browse the repository at this point in the history

  26. Fix endianness off RIFF size field (should be Little-Endian, was Big-… 

    …Endian)
    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    825da85 View commit details
    Browse the repository at this point in the history

  27. Normalize RIFF ID (FourCC) to exclude spaces on 'bean' level

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    395911b View commit details
    Browse the repository at this point in the history

  28. Remove ID3 header remainder

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    beec64f View commit details
    Browse the repository at this point in the history

  29. Add a unit test mocking Picard saving an ID3 header to a WAVE file.

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    a09c826 View commit details
    Browse the repository at this point in the history

  30. Resolve review

    @Borewit @phw
    Borewit authored and phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    c4374b8 View commit details
    Browse the repository at this point in the history

  31. Wave: Fixed style errors

    @phw
    phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9c2fd9b View commit details
    Browse the repository at this point in the history

  32. wave: Fixed tests

    @phw
    phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    e507764 View commit details
    Browse the repository at this point in the history

  33. Wave: Python 2 fixes

    @phw
    phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    b3abeeb View commit details
    Browse the repository at this point in the history

  34. wave: Code review fixes

    @phw
    phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    51cf54b View commit details
    Browse the repository at this point in the history

  35. wave: Added API docs

    @phw
    phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    9d29fbd View commit details
    Browse the repository at this point in the history

  36. wave: Renamed sample_size to bits_per_sample 

    For consistency with other formats.
    @phw
    phw committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    52274d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. riff: Minor documentation fixes

    @phw
    phw committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    e4f54e5 View commit details
    Browse the repository at this point in the history