Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
id3: Add option to combine id3v1/id3v2 tags during load #357
I think we can enable it by default as I can't think of any downsides. We don't support saving without updating id3v1 in some way so there is no chance of getting non-removable tags which get reloaded from id3v1 next time etc.
If we want to make it optional I think having a load_v1=True option which also affects the currently active no-v2-header fallback would be easier to understand.
Otherwise we lose things like TCON index translation. This changes one test result where a TYER frame in a v2.4 tag is replaced by the v1 TDRC. Since that is off-spec I don't think that will be a problem, and it will likely contain the same data anyway.