Wav bitrate fix #566
Merged
Wav bitrate fix #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phw
approved these changes
Jul 14, 2022
that's a Python 2 thing
|
thanks! |
sampsyo
added a commit
to beetbox/mediafile
that referenced
this pull request
Oct 25, 2022
Mutagen recently updated its policy for calculating this: quodlibet/mutagen#566 So we now match its output, and we require the version of Mutagen that produces this output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculated bitrate for WAVE files did not match correct value (as shown in foobar2000 or calculated manually)
Should be: num channels * bits per sample * sample rate
Tests for WAVE were checking incorrect values for bitrate. Redbook audio (stereo, 16bit, 44100Hz) for example should have a bitrate of 1411200 bits per second.