id3: handle negative extended header sizes #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazka
force-pushed
the
id3-negative-ext-header-size
branch
from
a1d2bad
to
dd9ed81
Compare
The extended header size is an integer, so can be negative. This leads to read_full() getting called with a negative size and failing with ValueError. Handle this case explicitly and raise a proper mutagen exception instead.
lazka
force-pushed
the
id3-negative-ext-header-size
branch
from
dd9ed81
to
bbbc9f1
Compare
phw
approved these changes
May 7, 2023
|
I guess that was found by the fuzzing tests, right? |
|
yeah, the first one, I wanted to see if oss-fuzz picks this up somehow. https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=58145 thanks for the review! |
|
it closed the oss-fuzz issue automatically now, nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extended header size is an integer, so can be negative. This leads to read_full() getting called with a negative size and failing with ValueError.
Handle this case explicitly and raise a proper mutagen exception instead.