Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar resizing #2556

Closed
elbeardmorez opened this issue Sep 6, 2017 · 6 comments
Closed

Sidebar resizing #2556

elbeardmorez opened this issue Sep 6, 2017 · 6 comments
Labels

Comments

@elbeardmorez
Copy link
Contributor

elbeardmorez commented Sep 6, 2017

@declension
The recent #152 work added a lovely sidebar which looks great, especially for embedded lyrics. However, just a small gripe in that one doesn't appear to be able to make the contents of the pane smaller than some fixed value, and thus extra unwanted white space persists. See the off-centered look of the lyrics in the pic below.

sidebar spacing issue

@declension
Copy link
Member

Thanks. Not sure if that fixes it, I couldn't see much difference. Still, it was definitely unnecessary now...

@elbeardmorez
Copy link
Contributor Author

elbeardmorez commented Sep 6, 2017

Excellent, thanks!

white space collapsing nicely!

@declension
Copy link
Member

Thanks for investigating 👍

@elbeardmorez
Copy link
Contributor Author

elbeardmorez commented Sep 10, 2017

should just add that if other sidebars are also open (e.g. Python Console) then they (well, 'it', in this example) seem to hinder the correct collapsing of the ViewLyrics pane. doesn't bother me at all, just noting!

@declension
Copy link
Member

Hmm, @elbeardmorez if you can please post a screenshot

@elbeardmorez
Copy link
Contributor Author

elbeardmorez commented Sep 11, 2017

open ViewLyrics alone
perfect
open Python Console
still perfect
move mouse on and off pane
why did the lyrics appear to move?
pane grows due to the content of the Python Console side bar, which appears to be wrapping its lines, but really slowly in the background. every time you move the move on/off the ViewLyrics content it disappears every so slightly more
where did my nicely centered lyrics go?
if you can pick out the red dot on the above image, that's where i had my mouse, moving a couple of pixels left, a couple right over and over.

note, on the Python Console word wrapping, my 'current working directory' is very long, and is the culprit for the 'needs to be wrapped' charge ..hence if your work is in /short/path then you might not see this.

flicking onto the actual Python Console and then manually resizing the sidebar bigger then smaller to 'force redraws' gets the line wrapped properly and from then on, switching back to the ViewLyrics pane there are no issues.

not sure what to suggest .."on enable any sidebar show it immediately to force it to realise its available space properly" ..or maybe there's something simpler, i've not looked. anyway, there are of course much bigger fish to fry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants