Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmkeys: dbus startup errors under mate #3056

Closed
lazka opened this issue Nov 14, 2018 · 1 comment
Closed

mmkeys: dbus startup errors under mate #3056

lazka opened this issue Nov 14, 2018 · 1 comment

Comments

@lazka
Copy link
Member

lazka commented Nov 14, 2018

Someone reported a regression: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913646
@lazka
Copy link
Member Author

lazka commented Nov 14, 2018

So, when mate-settings-daemon is running in a non-mate session it owns the name, but doesn't provide the interface. So in some weird DE mix where we don't find a mmkeys interface we fall back to mate because the name is owned and error out there.

We need to skip the mate backend in case the interface is not supported.

@lazka lazka changed the title dbus startup errors under mate mmkeys: dbus startup errors under mate Nov 16, 2018
lazka added a commit to lazka/quodlibet that referenced this issue Nov 16, 2018
@lazka
mmkeys/gnome: check that the dbus object supports the interface befor…
b260f3c 
…e using it. Fixes quodlibet#3056

When mate-settins-daemon is installed but mate isn't run it still gets started (at least under Debian)
but it doesn't provide the mmkeys interface. This resulted in the mate backen dbeing selected and
in an error on start.

This extends the code to check for the interface instead for the dbus name and also handles dbus errors
by logging them instead of preventing QL from starting.
@lazka lazka mentioned this issue Nov 16, 2018
Merged
lazka added a commit to lazka/quodlibet that referenced this issue Nov 16, 2018
@lazka
mmkeys/gnome: check that the dbus object supports the interface befor…
0d8410b 
…e using it. Fixes quodlibet#3056

When mate-settins-daemon is installed but mate isn't run it still gets started (at least under Debian)
but it doesn't provide the mmkeys interface. This resulted in the mate backen dbeing selected and
in an error on start.

This extends the code to check for the interface instead for the dbus name and also handles dbus errors
by logging them instead of preventing QL from starting.
lazka added a commit that referenced this issue Nov 18, 2018
@lazka
mmkeys/gnome: check that the dbus object supports the interface befor…
4d7ac73 
…e using it. Fixes #3056

When mate-settins-daemon is installed but mate isn't run it still gets started (at least under Debian)
but it doesn't provide the mmkeys interface. This resulted in the mate backen dbeing selected and
in an error on start.

This extends the code to check for the interface instead for the dbus name and also handles dbus errors
by logging them instead of preventing QL from starting.
@lazka lazka mentioned this issue Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lazka