togglemenubar: add auto-hide mechanism #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Do you think it's an improvement over the simple alt toggle? |
|
Yes, but a little bit strange that the menus tear down as soon as you hover over them. |
|
Yeah, I tried. I think it's because select_first() activates an event grab for the menu, which would normally happen on the first click on the menu. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is the best I can do for now.
The only functional difference with what Atom/Firefox do is that they require a first click to tear down a menu. Whereas this PR tears down menus as soon as the pointer enters the menu bar.
Any ideas to do better ?