New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

togglemenubar: add auto-hide mechanism #2267

Merged
merged 1 commit into from Feb 26, 2017

Conversation

Projects
None yet
2 participants
@ptitjes
Collaborator

ptitjes commented Feb 25, 2017

That is the best I can do for now.

The only functional difference with what Atom/Firefox do is that they require a first click to tear down a menu. Whereas this PR tears down menus as soon as the pointer enters the menu bar.

Any ideas to do better ?

@lazka

This comment has been minimized.

Member

lazka commented Feb 26, 2017

Looks good to me. Do you think it's an improvement over the simple alt toggle?

@ptitjes

This comment has been minimized.

Collaborator

ptitjes commented Feb 26, 2017

Yes, but a little bit strange that the menus tear down as soon as you hover over them.
Did you try it ?

@lazka

This comment has been minimized.

Member

lazka commented Feb 26, 2017

Yeah, I tried. I think it's because select_first() activates an event grab for the menu, which would normally happen on the first click on the menu.

@lazka lazka merged commit 65d6dc3 into quodlibet:master Feb 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lazka

This comment has been minimized.

Member

lazka commented Feb 26, 2017

Thanks!

@ptitjes ptitjes deleted the ptitjes:togglemenubar branch Feb 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment