tests: capture exceptions that are not caught during the test execution an reraise them. Fixes #2705 #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on an reraise them. Fixes quodlibet#2705 Exceptions raised during signals don't bubble to the test caller, instead they get pushed into sys.excepthook which by default prints them. This adds a pytest plugin which wraps each test (I think..) collects uncaught exceptions and reraises them at the end. This uncovers some bugs in the playlistbrowser tests. Most of the inherited tests were failing, and I think they never passed, so just remove the inheritance.
lazka
force-pushed
the
pytest-excepthook
branch
from
5b6025e
to
2aeea94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions raised during signals don't bubble to the test caller, instead they
get pushed into sys.excepthook which by default prints them.
This adds a pytest plugin which wraps each test (I think..) collects uncaught exceptions
and reraises them at the end.
This uncovers a few bugs, so this makes the tests fail atm.