Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searchbar: Don't save query on filter changes #2871

Merged
merged 2 commits into from May 30, 2018
Merged

searchbar: Don't save query on filter changes #2871

merged 2 commits into from May 30, 2018

Conversation

frestr
Copy link
Member

@frestr frestr commented May 30, 2018 •
edited

But rather on Return and - for eager searching - focus-out and Primary+Return accel.

@frestr frestr mentioned this pull request May 30, 2018
Closed
@frestr frestr changed the title searchbar: Only save query on focus-out searchbar: Don't save query on filter changes May 30, 2018
@frestr
searchbar: Only save query on focus-out
dc9f79a 
(And on Primary+Return accel).

I.e. don't save the query when the filter changes.
@frestr
searchbar: Explicitly save query on return
319eb21 
Now that filter changes don't.
@frestr frestr merged commit aeaf0d1 into quodlibet:master May 30, 2018
@frestr frestr deleted the save_query branch May 30, 2018 20:06
@marcelpaulo marcelpaulo mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@frestr