Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

searchbar: Don't save query on filter changes #2871

Merged
merged 2 commits into from May 30, 2018
Merged

Conversation

@frestr
Copy link
Member

@frestr frestr commented May 30, 2018

But rather on Return and - for eager searching - focus-out and Primary+Return accel.

@frestr frestr changed the title searchbar: Only save query on focus-out searchbar: Don't save query on filter changes May 30, 2018
frestr added 2 commits May 30, 2018
(And on Primary+Return accel).

I.e. don't save the query when the filter changes.
Now that filter changes don't.
@frestr frestr force-pushed the frestr:save_query branch from 66ffc88 to 319eb21 May 30, 2018
@frestr frestr merged commit aeaf0d1 into quodlibet:master May 30, 2018
6 checks passed
6 checks passed
ci/circleci: job.fedora28 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu16.04 Your tests passed on CircleCI!
Details
ci/circleci: job.ubuntu18.04 Your tests passed on CircleCI!
Details
ci/circleci: job.win32 Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frestr frestr deleted the frestr:save_query branch May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant