Add new Banshee import plugin #3141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin Plugin is currently a stub
Test is currently a stub, but it successfully generates an in-memory SQLite database
Phidica
commented
Mar 5, 2019
lazka
reviewed
Mar 12, 2019
catch an exception that was missed, fix use of ngettext, fix path conversion
|
Any more comments on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check-list
I've added / updated documentation for any user-facing features.(Not applicable)masterWhat this change is adding / fixing
Merging this pull request would add a new plugin that imports song information from the database of the Banshee music player, to improve the quality of life for users migrating from Banshee to QL. It was modelled after the pre-existing Rhythmbox importer and works similarly to match the URI stored in the Banshee db to songs QL has added. We import the ratings, play/skip counts, date of most recent play, and date added to library.
The Banshee database is SQLite, so we simply use the standard Python
sqlite3libary. No new dependencies are added.I have written and included a test program for the importer.
The plugin is no more complex than the Rhythmbox importer, and, as Banshee has ceased further development, would require very little future maintenance.