Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix punctuation of another simple tooltip #3219

Merged
merged 2 commits into from Jul 17, 2019

Conversation

Mellthas
Copy link
Contributor

Missed in #3208.

@declension
Copy link
Member

LGTM

@@ -4641,7 +4641,7 @@ msgid "Tag expression"
msgstr "Tag-udtryk"

#: ../quodlibet/qltk/data_editors.py:373
msgid "Tag expression e.g. people:real or ~album~year."
msgid "Tag expression e.g. people:real or ~album~year"
msgstr "Tag-udtryk. F.eks. people:real eller ~album~year."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the period was missed in the "Tag-udtryk..." line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like two sentences in the translation, so the translator might want to retain the ending punctuation.

Copy link
Contributor Author

@Mellthas Mellthas Jul 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But given all these uncertainties that arise, it might indeed be better in the future to not touch the PO files, and let the translators decide what to do; see #3218 (comment).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, the period after udtryk is surprising.

touch the PO files, and let the translators decide what to do; see #3218 (comment).

True. I wasn't aware about the fuzzy matching thing. That said, it still requires extra work from the translators and given that that work might only happen very rarely, I think updating in the very obvious cases still makes sense. But yeah, that's not the case here.

@@ -4726,7 +4726,7 @@ msgid "Tag expression"
msgstr "Expressão de etiqueta"

#: quodlibet/qltk/data_editors.py:371
msgid "Tag expression e.g. people:real or ~album~year."
msgid "Tag expression e.g. people:real or ~album~year"
msgstr "Expressão de etiqueta. Por exemplo, people:real or ~album~year."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another one in the "Expressão de etiqueta..." line. Rest looks good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@CreamyCookie CreamyCookie merged commit c2f79a8 into quodlibet:master Jul 17, 2019
@CreamyCookie
Copy link
Collaborator

Thanks!

@Mellthas Mellthas deleted the tooltip-fix branch July 17, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants