the sync_to_device plugin shouldn't delete files named 'cover.jpg' #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
declension
reviewed
Aug 13, 2022
declension
reviewed
Aug 13, 2022
declension
reviewed
Aug 13, 2022
| @@ -1079,14 +1081,18 @@ def _remove_empty_dirs(self): | |||
| for root, dirs, __ in os.walk(self.expanded_destination, topdown=False): | |||
| for dirname in dirs: | |||
| dir_path = os.path.realpath(os.path.join(root, dirname)) | |||
| if not os.listdir(dir_path): | |||
| files = os.listdir(dir_path) | |||
| last_file_is_cover = files and files[0] == 'cover.jpg' | |||
There was a problem hiding this comment.
That's the first file, no? What if there are lots and 'cover.jpg' just happens to be the first?
There was a problem hiding this comment.
If there are other files than the music and cover.jpg, deleting the folder will fail. And I think that is okay, since the user shall notice that's not the way how this plugin sync process is designed. Then an error message explaining that would be nice I think. What do you think?
There was a problem hiding this comment.
Ah, yeah that makes sense. Perhaps you could add a comment to explain this in the code...
Co-authored-by: Nick Boultbee <declension@users.noreply.github.com>
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4082