Track List: Add shortcut Ctrl-Return to the searchbar #4141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctrl-Return in the searchbar enqueues the complete songlist
|
Thanks! Elsewhere (e.g. songlist plugins) we have protection mechanisms above a threshold, that might be an idea here - e.g. a dialog that asks Are you sure you want to enqueue 5,234 files? or something |
Update the track list and the paned browser to use this variable. The actual confirmation request is implemented in QuodLibetWindow, and the advanced_preferences plugin allows the user to configure the limit, which defaults to 50.
I've pushed a new commit that ask for confirmation if the number of songs exceed a configurable limit. |
|
Thanks! |
nemethf
added a commit
to nemethf/quodlibet
that referenced
this pull request
Oct 11, 2022
As a follow-up to quodlibet#4141, document the new shortcut key.
4 tasks
declension
pushed a commit
that referenced
this pull request
Oct 20, 2022
As a follow-up to #4141, document the new shortcut key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl-Return in the searchbar enqueues the complete songlist
Check-list
masterWhat this change is adding / fixing
This is a follow-up to #2745 and #2701, because after four years I'm finally starting to use the "Track List" browser. I've now looked the rest of the browsers and I don't see how they could be extended with this feature. This pull request copies code from the implementation of the panned browser, so it results in code duplication. However, a substantial duplication is already present, so this PR doesn't change the status quo.
Once again, I am not able to find a place where the change should be documented.
docs/guide/shortcuts.rstis the obvious target, but I just don't know where to write what.If necessary, please, tell me how to refine the PR, and I'll do my best to update it. Thanks again.