Modernise entire preferences UI 🎨 #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert to Gtk.Switch everywhere. It's the one true way now. * Rework the player prefs too * Make prefs window a bit more resize-friendly * Simplify some UI elements * Use FlowBox for column headings * Add a few icons for consistency * Fix a few tooltips etc * Add a behavio(u)r frame for Player * Nicer margins
* Also make RG integer values * And fallback -12dB -> +6dB, higher than this is madness anyway * Format buffer slider as `s` not `seconds`
|
I tried to put the replay gain sliders in a table to align them. I don't know if it's the right way to do that... It's aligned but not perfect anyway...
|
|
Before: After: I think I like the original tab style better, but the rest of it looks nice.
|
* Also make RG integer values * And fallback -12dB -> +6dB, higher than this is madness anyway * Format buffer slider as `s` not `seconds`
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots
Song List Prefs (wide)
Playback Prefs (normal)