Add Stop command to Control menu #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toupeira
commented
Nov 29, 2022
| act = Action(name="Stop", label=_("Stop"), | ||
| icon_name=Icons.MEDIA_PLAYBACK_STOP) | ||
| act.connect('activate', self.__stop) | ||
| ag.add_action(act) |
There was a problem hiding this comment.
question: Should we add a keyboard shortcut?
Some suggestions: Ctrl+Shift+Space, Ctrl+Escape
There was a problem hiding this comment.
Maybe yes. Not Ctrl+Escape I'd say, that's too weird and might do things in some WMs
This adds a menu item to fully stop playback, which is currently only available through the CLI, and some other integrations like MPRIS.
toupeira
force-pushed
the
feature/add-stop-menuitem
branch
from
8f60cab
to
9679bde
Compare
|
Generally I think this is worth a try. If people don't want it they won't have to use it |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check-list
tests/test_qltk_quodlibetwindow.pyis currently very barebones, so I figured I'll skip this 馃槈mainWhat this change is adding / fixing
This adds a menu item to fully stop playback, which is currently only available through the CLI, and some other integrations like MPRIS.
Screenshot: