Fix shuffle history #4255
Merged
Fix shuffle history #4255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: I guess we do need a strong "songlike type" than Any. |
|
(I think the Windows job is failing because of a different version of anyway it just wants an annotation on |
slosd
force-pushed
the
fix-shuffle-history
branch
from
ed7aa31
to
1dd6703
Compare
declension
approved these changes
Jan 23, 2023
slosd
commented
Jan 23, 2023
Instead of replacing the whole list reorder the existing one. This allows play order implementations to continue to use any saved TreeIters. Fixes quodlibet#4108
This reverts commit 68ba678.
slosd
force-pushed
the
fix-shuffle-history
branch
from
1dd6703
to
8448d31
Compare
|
Thanks @slosd ! |
This was referenced Sep 27, 2023
declension
added a commit
that referenced
this pull request
Sep 27, 2023
This reverts commit 500d0d1.
declension
added a commit
that referenced
this pull request
Sep 27, 2023
Revert "Fix shuffle history (#4255)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check-list
mainWhat this change is adding / fixing
Reset play order in queue for new set of songs
Used a specialized
QueueModelbecause the testtest_random_queue_666requires behavior that's slightly different fromPlaylistModel.Preserve shuffle history when songlist is reordered
Reorder songlist in place
Instead of replacing the whole list reorder the existing one. This
allows play order implementations to continue to use any saved
TreeIters.
Fixes #4108
Revert "Ignore auto_sort when shuffle is enabled (#3581)"
This reverts commit 68ba678. This limitation shouldn't be necessary anymore.