Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unique filters plugin #4264

Merged
merged 1 commit into from Feb 13, 2023
Merged

Conversation

LoveIsGrief
Copy link
Contributor

Check-list

There don't seem to be any tests for plugins?

  • I've added / updated documentation for any user-facing features

Is the plugin description enough?

  • Performance seems to be comparable or better than current main

What this change is adding / fixing

This plugin allows filtering by a unique tag e.g @(unique: artist) which will result only one song showing up per artist. It can be used multiple times e.g if one has mix albums in the library (albums with multiple artists),
it's possible to use &(@(unique: artist), @(unique: album)) to have one song per artist and one song per album

@LoveIsGrief LoveIsGrief force-pushed the unique-filters branch 6 times, most recently from 99a8a1e to 29f20d2 Compare February 6, 2023 21:24
@LoveIsGrief
Copy link
Contributor Author

This should be ready now 🙂

Copy link
Member

@declension declension left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM generally, thanks!

quodlibet/ext/query/unique.py Outdated Show resolved Hide resolved
This plugin allows filtering by a unique tag e.g `@(unique: artist)` which will result only one song showing up per artist.
It can be used multiple times e.g if one has mix albums in the library (albums with multiple artists),
 it's possible to use `&(@(unique: artist), @(unique: album))` to have one song per artist and one song per album
@LoveIsGrief
Copy link
Contributor Author

Thanks for the review @declension . I hope it's alright now.

@declension declension merged commit 9d2a5ab into quodlibet:main Feb 13, 2023
@declension
Copy link
Member

Thanks!

@LoveIsGrief LoveIsGrief deleted the unique-filters branch February 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants