Switch use libgit2 for diff, remove runtime dependency on git #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quodlibetor
force-pushed
the
libgit2-diff
branch
3 times, most recently
from
4a18095
to
439b389
Compare
quodlibetor
force-pushed
the
libgit2-diff
branch
3 times, most recently
from
c0bc930
to
3c1f5d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was only one remaining use of the external git dependency in git-instafix, and it was just to print diffs.
Replacing that with our home-grown git diff code is currently a slightly worse experience (it doesn't respect user's git diff config) but it is good enough, and it sets this up for a long term of having significantly more control.
This also resolves a slight annoyance in the nix package (from this comment)