New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(logger): reduce disk writes and improve privacy #541

Merged

ACTCD merged 1 commit into main from refactor/logger

Sep 19, 2023

Collaborator

ACTCD commented Sep 17, 2023

Migrate to structure Logger from using the Legacy Logging Symbols
Improve usage of log levels so that most logs will no longer be persisted to disk
Improve log content and use the privacy options for dynamically generated data
Improve dev and debug experience that can log more data types besides strings
Use fileID to fill the log category to facilitate filtering, can be further refined in the future

Todo in future: add a setting to turn off by default to output logs only when user needed


          refactor: use logger instead of os_log

b0df442

ACTCD requested a review from quoid

September 17, 2023 22:53

quoid approved these changes

View reviewed changes

Owner

quoid left a comment

This is great and running it locally worked as expected, I didn't see any noticeable issues. 🙇

ACTCD merged commit 2770401 into main

1 check passed

ACTCD deleted the refactor/logger branch

September 19, 2023 03:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment