Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update dev and build process and improvements #560

Merged
merged 17 commits into from
Oct 27, 2023
Merged

refactor: update dev and build process and improvements #560

merged 17 commits into from
Oct 27, 2023

Conversation

ACTCD
Copy link
Collaborator

@ACTCD ACTCD commented Oct 22, 2023 •
edited

  • Adjust and optimize the project directory structure to make it clearer and easier to expand
  • Content scripts and background script can build with ES modules
  • Import the original iOS App WebView project code
    • Migrate to app-shared group for future sharing with macOS app
  • Porting fix from fix: correctly returns xhr errors when type is blob #558
  • Some minor tweaks and optimizations to the iOS App WebView
    • Show informative text when using the default app document
    • Improved rendering flickering through min-height and min-width
    • Click on the current directory text to open the folder in Files app
  • Refactor the APIs append and injection process of user scripts in content scripts

This PR is also alternative implementation of 58d6530 from #478

@ACTCD
refactor(dev): adjust xcode structure
bdfdf08
@ACTCD
refactor(dev): adjust src structure
fd7b575
@ACTCD
refactor(dev): update build process and references
e4f4d5c
@ACTCD
refactor(app): import ios app webview src
3ed1bdc
@ACTCD
refactor: migrate ios webview to app-shared group
b3295e2
@ACTCD
refactor(preferences): centralize common functions to simplify calls
3470b84
@ACTCD
fix: correctly returns xhr errors when type is blob
ba8d8b6 
porting commit fa2641b from pr #558 fix issue #555
@ACTCD
refactor(app): update loading of ios app webview
69bb257
@ACTCD
refactor: update dev and build of ios app webview
61f82b9
@ACTCD
refactor(dev): improve produce of ext manifest.json
5f99654 
can easily use different sources of `manifest.json` files
extension version number are automatically introduced
distinguish extension name or icons in different config
all done automatically during the Xcode build process
@ACTCD
refactor: update webview action policy and fail handler
44a58ea
@ACTCD
feat(app): click on the directory to open the folder
243f27a
@ACTCD
refactor: improve package and types import
69fb292
@ACTCD
refactor: improve content scripts
a64f3e0 
only parse userjs code without apis precode
reduce computation and avoid js minify errors
inject into page with closed ShadowRoot for better security
@ACTCD ACTCD requested a review from quoid October 22, 2023 13:08
quoid
quoid reviewed Oct 23, 2023
View reviewed changes
scripts/build-ext-v4.js Outdated Show resolved Hide resolved
quoid
quoid reviewed Oct 23, 2023
View reviewed changes
scripts/build-ext-v5.js Outdated Show resolved Hide resolved
quoid
quoid approved these changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@quoid quoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, thank you for the massive effort. Running the builds locally seem to work as expected. Awesome job with this.

@ACTCD ACTCD requested a review from quoid October 26, 2023 21:49
@ACTCD ACTCD merged commit 48c6962 into main Oct 27, 2023
1 check passed
@ACTCD ACTCD deleted the dev/update-dev-and-build-process branch October 27, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quoid quoid quoid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Userscripts with quotes in their names break
2 participants
@ACTCD @quoid