refactor(dev): setup jsconfig and type checking and fixes #570

ACTCD · 2023-11-09T12:59:29Z

This PR is mainly to reimplement 7b49515 from @quoid PR #478

Set up different project-level jsconfig.json and .d.ts files
- Enable checkJS type checking for JavaScript
Fixes new errors generated by type checking and some improvements
- Some deep-path Svelte type errors are left unmodified, left to refactor in future
- Harmonization and revise the return values of GM APIs to Promise

Co-authored-by: quoid <7660254+quoid@users.noreply.github.com>

src/ext/shared/dev.js

Co-authored-by: Justin Wasack <7660254+quoid@users.noreply.github.com>

ACTCD and others added 2 commits November 6, 2023 06:06

refactor(dev): setup jsconfig and type checking

9e8a6d0

Co-authored-by: quoid <7660254+quoid@users.noreply.github.com>

refactor: fix new errors generated by type checking

58fff01

ACTCD requested a review from quoid November 9, 2023 12:59

quoid reviewed Nov 10, 2023

View reviewed changes

src/ext/shared/dev.js Outdated Show resolved Hide resolved

quoid approved these changes Nov 10, 2023

View reviewed changes

ACTCD and others added 3 commits November 10, 2023 10:10

refactor: few minor tweaks

378dca5

refactor: detailed type definitions instead of any

a4559fc

Co-authored-by: Justin Wasack <7660254+quoid@users.noreply.github.com>

refactor: correct error message text typo

d2d75c2

ACTCD merged commit a909ed3 into main Nov 11, 2023
1 check passed

ACTCD deleted the dev/jsconfig branch November 11, 2023 09:00

This comment was marked as spam.

Sign in to view

ACTCD mentioned this pull request Apr 24, 2024

script not work on safari in iphone, while working well on chrome in computer. #647

Closed

Provide feedback