[Criterion] Add support for quicktest.run all #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit kind of reverts the decision taken in 6d44ebe and once again runs tests through the `meson test` CLI. It does not matter all that much when testing 1 file (or 1 executable) but makes a huge difference when attempting to run all tests in a project * Add utility function for capturing the test output (json) in a text stream * Get exe from buffer returns meson target instead of full path to exe
oyvindaakre
force-pushed
the
criterion/support-run-all
branch
from
32b4821
to
a9aeb16
Compare
|
@oyvindaakre blindly merge, cause don't want to setup criterion 🥲 Thanks for the fix! |
|
Haha 😂 I bet I'm the only user of the adapter anyway :P If you ever feel like it, I added a readme in the test dir that should include how to setup the test project :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
This PR adds support for
quicktest.run_allin thecriterionadapter by running all tests from the build directory defined by the user.Changed
In order to support this, I semi-reverted my previous change here 6d44ebe
so that all tests are (again) run through
meson test. It makes no difference to the user, but it makes the adapter more streamlined when it comes to running test and made it straight-forward to supportrun_all.