While Loops: handle exiting a loop from within a conditional block #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested changes
Mar 8, 2022
JelleZijlstra
approved these changes
Mar 8, 2022
|
The self-check is still failing on 3.6 because the I'm going to look into why we don't catch this on 3.7+. |
|
I can update that. does the type for the base Scope class not need to be changed? |
Yes I think so. That's another thing that pyanalyze should catch by itself. |
JelleZijlstra
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic doesn't recognize that you can break out of loops inside of an
ifstatement, since it only checks forLEAVES_LOOPin the main scope.