put short delay between each publish in RepublishAll #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
reviewed
Jun 21, 2019
republisher/main.go
Outdated
| return net.(*network.RemoteNetwork).RepublishAll() | ||
| err = net.(*network.RemoteNetwork).RepublishAll() | ||
| if err != nil { | ||
| panic(errors.Wrap(err, "error on publish")) |
There was a problem hiding this comment.
Isn't it better to return the error here, since the function has an error return type?
|
failure is due to dgraph-io/badger#886 |
|
i just pushed rebuild on this. |
tobowers
reviewed
Jun 25, 2019
republisher/main.go
Outdated
| @@ -52,7 +57,12 @@ func doIt(ctx context.Context) error { | |||
| panic(errors.Wrap(err, "setting up network")) | |||
There was a problem hiding this comment.
error return here too I guess (but I realize that was the old code)
brandonwestcott
force-pushed
the
republish-temp-fix
branch
from
fc49844
to
cb85074
Compare
added 2 commits
June 28, 2019 11:10
theory is that community block store is filling up its ingress buffer inside libp2p
brandonwestcott
force-pushed
the
republish-temp-fix
branch
from
cb85074
to
4e39914
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blocks were getting published on andrew's box, but weren't appearing on the community hub node. Theory is that community block store is filling up its ingress buffer inside libp2p, so putting a short delay between