Timeline: restore Item#message
height shrink ability
#612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This got broken by dbda393 which introduced circular dependency on height:
Item#message
height was dependent onchildrenRect.height
but it included aMouseArea
which was dependent onparent.height
.It turned out by 87b18d9 via changing
discardButton
type fromActiveLabel
toToolButton
which is taller and forces sent messages to shrink when it gets invisible (in normal circumstances, shortly after it appears).