Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support body in response #10

Closed
4 tasks done
KitsuneRal opened this issue Oct 7, 2017 · 0 comments
Closed
4 tasks done

Support body in response #10

KitsuneRal opened this issue Oct 7, 2017 · 0 comments
Projects

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Oct 7, 2017

As of f3d4f3b, GTAD can parse object schemas, including those in the response. Next steps are:

  • Move the response structure from CallClass to Call in the model (thereby accepting cases when the two calls having the same name might have different response types - but having two calls with the same name is forbidden by the Swagger spec, anyway).
  • Remove the code that checks the response for non-triviality and move the whole block that analyzes the result schema after a Call object creation.
  • In Printer, use the (now useable) response structure to fill in correct context values
  • In libqmatrixclient code, use the context values (the current blocks of code refer to variables that don't exist in Swagger's intermediate JSON).
@KitsuneRal KitsuneRal created this issue from a note in GTAD 1 (Version 0.3 - To Do) Oct 7, 2017
KitsuneRal added a commit to quotient-im/libQuotient that referenced this issue Oct 10, 2017
This addresses the last bullet in quotient-im/gtad#10, completing the implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
GTAD 1
  
Version 0.3 - Done
Development

No branches or pull requests

1 participant