Crash on sync (Malformed userId)

[Midek]

Description

After loging in to my account, quaternion tries to sync and segfaults, pointing at a malformed user Id:

quotient.main: Malformed userId: "@a_null_punisher:nerdsin.space,"
quotient.main: Could not get a user object for "@a_null_punisher:nerdsin.space,"
quotient.main: Malformed userId: "@a_null_punisher:nerdsin.space,"
zsh: segmentation fault (core dumped)  quaternion

this likely related to a ban event that had a typo:

              "content": {
                "membership": "ban",
                "reason": "Account of banned user"
              },
              "origin_server_ts": 1612936420977,
              "sender": "@abuse:glowers.club",
              "state_key": "@a_null_punisher:nerdsin.space,",
              "type": "m.room.member",
              "unsigned": {
                "age": 1391916011
              },
              "event_id": "$go250HDglZ6rzR2aKluhe1ExU9IG_fQe1EK6L1dNYnA"
            },

Steps to reproduce

• Have someone send a broken ban event
• quaternion crashes, and trying to restart crashes every time

Expected behavior:
Quaternion ignores malformed id and keeps working

Version information

• Quaternion version: 0.0.9.5-3
• Qt version: 5.15.2-5
• Install method: Archlinux AUR
• Platform: Arch GNU/Linux

[KitsuneRal]

Thanks - the current code is indeed too sensitive to user ids.

[KitsuneRal]

For the record: problematic libQuotient versions are 0.6.2 through 0.6.5. Within 0.6.x branch, upgrade to 0.6.6 is strongly recommended.

[KitsuneRal]

Closed by the commit listed above.