Update to Matrix v1.7 #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default values for fields, unlike parameters passed to constructors, were completely missing before. This commit introduces initializers to non-omittable fields, and uses fillFromJson() instead of fromJson() to preserve those defaults when nothing is found in JSON instead. GTAD 0.9 is needed to generate structures with required fields first, optional after.
|
Kudos, SonarCloud Quality Gate passed! |
TobiasFella
reviewed
Jun 6, 2023
Looks like it's misplaced in the original matrix-spec repo.
TobiasFella
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of 0.8 beta preparation, I pulled almost-freshest
matrix-spec; routinely applying the changes broke the build, revealing the problem with default field values - unlike constructor arguments, fields never had default values. Fixing that required a small change in GTAD, and since the order in some structures has changed, code that list-initialises them may break as a consequence (I don't think we have any, across the two clients but I might've missed something).