Forward-port 0.8.x fixes #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[skip ci]
Benefits from replacing endl with \n are rather questionable, in fact: https://www.modernescpp.com/index.php/c-core-guidelines-improved-performance-with-iostreams/ [skip ci]
Cherry-picked from 5dfe09e, except that deprecations ignored in 0.8.x are kept for later tackling here.
It's meant to indicate text decoding problems and things like Sonar complain about it in the logs (rather legitimately, I'd say).
The commit adds very naive retries to quotest's DownloadRunner, while the proper fix for #727 is in the works.
There was a wrong assumption that the message with the final report will always get sent last. This is not true when 429's occur, as the library may reorder sending events (related issue: #133). Moreover, this actually was premature optimisation because the code checks for messages reaching the homeserver anyway. Once these two lines are gone, the code starts doing exactly what the comments next to it say, and exits promptly after the last message reaches the homeserver.
KitsuneRal
force-pushed
the
kitsune/forward-porting
branch
from
8e01777
to
972d865
Compare
TobiasFella
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just cherry-picking things thrown into 0.8.x branch after branching and before 0.8.2 release.