Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update membersTyping #753

Merged
merged 1 commit into from
May 6, 2024
Merged

Update membersTyping #753

merged 1 commit into from
May 6, 2024

Conversation

nvrWhere
Copy link
Contributor

@nvrWhere nvrWhere commented May 6, 2024

Make membersTyping a Q_PROPERTY as this makes more sense since it's just a value.

Also add otherMembersTyping as a useful specialisation as this is what we generally want in neochat

@nvrWhere
Make membersTyping a Q_PROPERTY as this makes more sense since it's j…
d5df25d 
…ust a value.

Also add otherMembersTyping as a useful specialisation as this is what we generally want in neochat
KitsuneRal
KitsuneRal approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@KitsuneRal KitsuneRal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KitsuneRal KitsuneRal merged commit 621cb93 into quotient-im:dev May 6, 2024
4 of 5 checks passed
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label May 6, 2024
@KitsuneRal KitsuneRal added this to In work in libQuotient 1 via automation May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KitsuneRal KitsuneRal KitsuneRal approved these changes

Assignees
No one assigned
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
Status: 0.9 - Done
libQuotient 1
  
In work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nvrWhere @KitsuneRal