Skip to content

Commit

Permalink
Merge pull request #74 from qupath/0.4
Browse files Browse the repository at this point in the history
Sync to v0.4
  • Loading branch information
petebankhead committed Sep 1, 2023
2 parents f9c7adb + a0802c5 commit b733d46
Show file tree
Hide file tree
Showing 10 changed files with 18 additions and 17 deletions.
4 changes: 2 additions & 2 deletions docs/deep/bioimage.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ It also provides test inputs and outputs, so it's possible to check the results
QuPath aims to support the zoo via the [QuPath Bioimage Model Zoo extension](https://github.com/qupath/qupath-extension-bioimageio).

The overall aim is to enable models kept in the Zoo to be imported into some QuPath-friendly form.
Currently, the zoo contains a lot of models devoted to image segementation - so the extension focusses on converting these models to QuPath pixel classifiers.
Currently, the zoo contains a lot of models devoted to image segmentation - so the extension focusses on converting these models to QuPath pixel classifiers.


:::{admonition} Adding Deep Java Library
Expand Down Expand Up @@ -126,4 +126,4 @@ QuPath currently aims to support:
* TensorFlow saved model bundles (you'll need to unzip the bundle)... assuming you're not using Apple silicon
* PyTorch *using Torchscript only*
* ONNX *might* work via QuPath's built-in OpenCV (if you're very lucky), or if you [build QuPath from source](building) adding the OnnxRuntime engine to DJL
:::
:::
4 changes: 2 additions & 2 deletions docs/deep/djl.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ If the download is successful, the indicator beside the engine should switch to

:::{admonition} Why an extension?
The *QuPath Deep Java Library extension* is at an early stage and under active development.
Keeping it as a separate extension allows us to make updates ithout needing to make an entirely new QuPath release.
Keeping it as a separate extension allows us to make updates without needing to make an entirely new QuPath release.

In the future, it might well become included in QuPath by default.

Expand Down Expand Up @@ -337,4 +337,4 @@ This only begins to scratch the surface of possibilities for deep learning suppo
Because Groovy gives access to all of QuPath and all of DJL, a lot more can already be done by scripting - including loading, and even training, your own models.
Check out the DJL documentation for more details.

Over time, the QuPath extension and docs will be updated as we make deep learning easier to use without needing to grapple with DJL directly.
Over time, the QuPath extension and docs will be updated as we make deep learning easier to use without needing to grapple with DJL directly.
7 changes: 4 additions & 3 deletions docs/intro/installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,12 @@ However, as an open source project, we don't currently have the time and resourc
(apple-silicon)=
#### Apple Silicon

v0.4.0 introduces a new (experimental) QuPath build specifically for Apple Silicon.
To use the 'default' (Intel) build of QuPath on a recent Mac with an Apple Silicon processor, you'll need to have Rosetta 2 installed.
There is a good chance you already have it (e.g. if you're using any other software written for Intel processors), but if not there are [more details on Apple's website](https://support.apple.com/en-gb/HT211861).

If you have a new Mac with an M1/M2 processor, this is likely to run much faster than the alternative Intel build.
QuPath v0.4.0 *also* introduces a new (experimental) QuPath build specifically for Apple Silicon, which doesn't require Rosetta 2.
If you have a new Mac with an M1/M2 processor, this is likely to run much faster than the alternative Intel build - but unfortunately has some significant disadvantages:

*However*, there are a few significant disadvantages:
* OpenSlide is missing. You can add it separately with the help of [Homebrew](https://brew.sh) - see <https://github.com/petebankhead/homebrew-qupath> for details
* Images opened with Bio-Format may not work if they require a native library, e.g.
* some .ndpi files (e.g. the OS-1/OS-2/OS-3.ndpi sample images)
Expand Down
4 changes: 2 additions & 2 deletions docs/reference/faqs.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ There is some info about adding GPU support for specific cases in {ref}`building
However, note that many bottlenecks depend upon things that cannot be solved by the GPU alone (e.g. reading image tiles, the user interface thread).
Therefore the real-world impact on performance may be quite modest for many applications.

The interactive machine learning uses OpenCV as the processing library, which uses the CPU (but highly-optimzed).
The interactive machine learning uses OpenCV as the processing library, which uses the CPU (but highly-optimized).
It is designed so that other machine learning libraries could potentially be used, if suitable extensions are written.

### Why do I see a warning when I try to install QuPath?
Expand Down Expand Up @@ -187,7 +187,7 @@ See {ref}`Open URI` for more details.

### Why does my image open but look weird?

See [Why can't QuPath open my image?]
See {ref}`Why can't QuPath open my image?`

### Is it possible to view slide labels?

Expand Down
2 changes: 1 addition & 1 deletion docs/scripting/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ You can find QuPath's API docs at <http://qupath.github.io/javadoc/docs/>

## Default imports

In the *Script Editor*, there is an option {menuselection}`Run --> Include default bindings`.
In the *Script Editor*, there is an option {menuselection}`Run --> Include default imports`.

If this is selected, QuPath will add the following line to the top of your script:

Expand Down
4 changes: 2 additions & 2 deletions docs/starting/first_steps.md
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ For more information on the strange use of the word *descendant*, see {doc}`../c
Next, try creating detection objects inside an annotation.
First, draw an annotation in an area of the image containing cells - ideally quite small, to contain perhaps 100 cells.

Run the {menuselection}`Analyze --> Cell analysis --> Cell detection` command.
Run the {menuselection}`Analyze --> Cell detection --> Cell detection` command.
This should bring up an intimidating list of parameters to adapt the detection to different images.
If you like you can explore these, and hover the mouse over each parameter for a description - but for now, you can also just ignore them and use the defaults (which tend to behave sensibly across a range of images).

Expand Down Expand Up @@ -326,7 +326,7 @@ As your collections of objects grow on the image, it may start to become clutter
There are four useful toolbar buttons that can help customize how the objects are displayed. These are:

- {{ icon_annotations }} **Show and hide annotations** - shortcut {kbd}`A`
- {{ icon_tma_grid }} **Show and hide a TMA grid** (only relevant for \[\[Tissue microarrays\]\]) - shortcut {kbd}`G`
- {{ icon_tma_grid }} **Show and hide a TMA grid** (only relevant for tissue microarrays) - shortcut {kbd}`G`
- {{ icon_detections }} **Show and hide detections** - shortcut {kbd}`D`
- {{ icon_detections_fill }} **Fill and unfill detections** - shortcut {kbd}`F`

Expand Down
2 changes: 1 addition & 1 deletion docs/starting/help.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Here are the main sources of help with QuPath questions:
- [Twitter](https://twitter.com/QuPath) - most things will be **announced here first**

:::{tip}
There's also a fantastic forum post introducing QuPath from a user's perspective [here](https://forum.image.sc/t/qupath-intro-choose-your-own-analysis-adventure/27906). Please note this post refers to verison 0.2.0 and there has been a few updates since then!
There's also a fantastic forum post introducing QuPath from a user's perspective [here](https://forum.image.sc/t/qupath-intro-choose-your-own-analysis-adventure/27906). Please note this post refers to version 0.2.0 and there has been a few updates since then!
:::

If your needs for instruction are more modest, it's always worthwhile to try hovering your mouse over nearby buttons or input controls - there's a good chance that an explanation will pop up to explain what the control does.
Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/cell_detection.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ Ki67 image with annotation

### Run *Positive cell detection*

Run the {menuselection}`Analyze --> Cell analysis --> Positive cell detection` command.
Run the {menuselection}`Analyze --> Cell detection --> Positive cell detection` command.
This will bring up a dialog, where most of the options relate to how the cells are detected.
The default values are often good enough to get started.

Expand Down
2 changes: 1 addition & 1 deletion docs/tutorials/projects.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Simply add the *project.qpproj* file from another compatible QuPath project to b

#### Remove images

You can remove images by right-clicking one or more entries under the *Project* tab and choosing {menuselection}`Delete image(s)`.
You can remove images by right-clicking one or more entries under the *Project* tab and choosing {menuselection}`Remove image(s)`.

You can choose whether to also delete all associated data from within the project (e.g. annotations).
If you choose not to, these files will linger around - you won't be able to access them easily (because the image isn't in the project), but they may be retrievable in an emergency.
Expand Down
4 changes: 2 additions & 2 deletions docs/tutorials/separating_stains.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Brightness/Contrast tool and channel viewer with a multiplexed image.
:::

:::{tip}
{menuselection}`View --> Mini viewers --> Channel viewer` can be used to visualize all separated channels simultaneously.
{menuselection}`View --> Show channel viewer` can be used to visualize all separated channels simultaneously.
:::

:::{tip}
Expand Down Expand Up @@ -280,7 +280,7 @@ In this case, {kbd}`1` will show the original image, {kbd}`2` hematoxylin, {kbd}
:::{admonition} Questions & Answers
**Why does \*Estimate stain vectors\* matter?**

If the stain vectors are sufficiently wrong, then commands that make use of cell detection (e.g. cell detection) may perform badly, because information from different stains is being mixed up.
If the stain vectors are sufficiently wrong, then commands that make use of color deconvolution (e.g. cell detection) may perform badly, because information from different stains is being mixed up.

The can also lead to strange or impossible results, such as cells being measured as having 'negative' amounts of particular stains.

Expand Down

0 comments on commit b733d46

Please sign in to comment.