Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showConfirmDialog method never uses its title parameter #662

Closed
melvingelbard opened this issue Jan 21, 2021 · 1 comment
Closed

showConfirmDialog method never uses its title parameter #662

melvingelbard opened this issue Jan 21, 2021 · 1 comment
Labels
bug
Milestone
v0.3.0

Comments

@melvingelbard
Copy link
Contributor

Bug report

Describe the bug
showConfirmDialog() in the Dialogs class never uses the title parameter, and uses the text as a title instead. This results in confirm dialogs showing their text in the main content pane as well as in their title.

Expected behavior
The title is used as title and text as main text.

Desktop (please complete the following information):

  • OS: All
  • QuPath Version 0.2.3

Additional context
The issue is located here.
There are around 30 calls to this method in other parts of the code.
@petebankhead petebankhead added this to the v0.3.0 milestone Jan 27, 2021
petebankhead added a commit to petebankhead/qupath that referenced this issue Apr 4, 2021
@petebankhead
Fix showConfirmDialog(title, text) bug
181807a 
See qupath#662
@petebankhead petebankhead mentioned this issue Apr 4, 2021
Merged
@petebankhead
Copy link
Member

Fix will be in v0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@petebankhead @melvingelbard