Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMEPyramidWriter logic for bigtiff can fail for image pyramids #858

Closed
petebankhead opened this issue Dec 14, 2021 · 0 comments
Closed

OMEPyramidWriter logic for bigtiff can fail for image pyramids #858

petebankhead opened this issue Dec 14, 2021 · 0 comments
Assignees
Labels
Milestone

Comments

@petebankhead
Copy link
Member

Bug report

Describe the bug
The logic used here to identify whether a bigtiff should be written appears to be incorrect, because it ignored multiple resolutions (and any space required for IFDs etc.).

To Reproduce
Difficult, because it requires an image that is on the borderline of what is acceptable.

But see https://forum.image.sc/t/qupath-out-of-memory-problem-when-creating-training-image/60985/5 for a case where I think that has happened.

Expected behavior
QuPath should always write bigtiff when it needs to. Multiple resolutions should be included in any calculation.

It might be necessary to provide the user with a way to control this.

Desktop (please complete the following information):

  • OS: All
  • QuPath Version 0.3.0

Additional context
This can be difficult to discern in advance whenever compression is involved.

The logic used for setting the bigtiff flag automatically in Bio-Formats is in TiffWriter (but it applies only if the image is uncompressed, and it's not totally clear to me if it uses the multiple resolutions).

@petebankhead petebankhead added this to the v0.3.1 milestone Dec 14, 2021
@petebankhead petebankhead self-assigned this Dec 14, 2021
petebankhead added a commit to petebankhead/qupath that referenced this issue Dec 14, 2021
Fixes for
* qupath#857
* qupath#858
This introduces the ability to write some other file formats using OMEPyramidWriter.
It also adds the ability to specify --big-tif with the convert-ome command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant