Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fragments & holes doesn't remove small objects from the current selection #976

Closed
petebankhead opened this issue May 31, 2022 · 0 comments · Fixed by #979
Closed
Assignees
Labels
Milestone

Comments

@petebankhead
Copy link
Member

Bug report

Describe the bug
Whenever Objects → Annotations... → Remove fragments & holes would result in an entire annotation being removed, it lingers in the selection until the selection is reset.

In other words, it looks like it was not deleted - and remains included in the selection model - even though it was really removed from the hierarchy.

To Reproduce
Steps to reproduce the behavior:

  1. Open an image and add some annotations of varying sizes
  2. Select all the annotations
  3. Run Objects → Annotations... → Remove fragments & holes and set thresholds that should case a subset of annotations to be removed
  4. Observe that the objects that should be removed continue to appear selected
  5. Reset the selection, e.g. by double-clicking elsewhere with the Move tool selected6.
  6. Observe that the small objects were removed after all

Expected behavior
The objects that are removed from the hierarchy are also removed from the selection.

Desktop (please complete the following information):

  • OS: All
  • QuPath Version 0.3.2 (probably earlier)

Additional context
It was reported elsewhere that Remove fragments & holes sometimes behaves inconsistently and doesn't delete fragments as expected. I'm not sure if this is the same problem or a different one.

@petebankhead petebankhead added this to the v0.4.0 milestone May 31, 2022
@petebankhead petebankhead self-assigned this May 31, 2022
petebankhead added a commit to petebankhead/qupath that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant