Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr reading and writing support #1474
Zarr reading and writing support #1474
Changes from 20 commits
2fa9b6c
a7b184f
d475f92
21b43e0
d7fc43a
00d05ff
59ac700
c2528f0
e8af370
604e585
3b177d6
c60cc86
8425109
a1af13c
e3718bc
a0ffcf7
a1e2172
768c05c
abe5c4e
e8f9666
16ab826
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
round
orfloor
? My intuition saysround
but my intuition isn't certain...Also, it would be useful to look at the number of
z
slices for different levels in the sample images you have access to. It might be possible to compute the ratio between thez
slices for a level and the zero level, to determine how much to rescale thez
index (which might be more robust than using thedownsample
value, in case it's possible that the downsampling inz
uses a different factor).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to use
round
but I got an error whenz / tileRequest.getDownsample()
was giving something like 133.5, which turned into 134 after applyinground
, when the max possible value was 133.