Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove run task dependency on getJavadocs #1518

Merged
merged 2 commits into from
May 7, 2024

Conversation

Rylern
Copy link
Contributor

@Rylern Rylern commented May 6, 2024

@Rylern Rylern changed the title Removed run task dependency on getJavadocs Remove run task dependency on getJavadocs May 6, 2024
@petebankhead
Copy link
Member

Excellent, thanks - can confirm that

./gradlew clean run

doesn't include the javadocs, but

./gradlew clean getJavadocs run

does. And they are also included with

./gradlew clean jpackage

Only minor comment is that getJavadocs doesn't seem a very gradle-ish task name and isn't so descriptive (use gradlew tasks to see all those that are available). What do you think of

assembleJavadocs Copies the Javadoc jars to a directory for access within QuPath

?

@Rylern
Copy link
Contributor Author

Rylern commented May 7, 2024

Yes

@petebankhead petebankhead merged commit e5e708e into qupath:main May 7, 2024
3 checks passed
@Rylern Rylern deleted the remove-copy-javadoc-from-run branch May 7, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants