Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scatter plot in measurement table & two measure classifier #1544

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alanocallaghan
Copy link
Contributor

First draft implementation of two measurement classifier and scatter plots in measurement viewer (along with histograms). Ideally I think these two panes should be merged, with an X and Y dropdown. If X or Y alone is selected, or if ==Y, then do a histogram. If both are selected and different, do a scatter plot. Saves space and I doubt many people will want to see histogram & scatter plot at the same time.

Two measurement classifier currently uses composite classifier, but really it should be something like a "union" classifier... or some kind of logical operand classifier. But I'm not currently sure what or how. The point colours on the scatter plot should also probably live update.

The code here is horrendous and needs to be refactored in both cases, but works as a POC.

@alanocallaghan
Copy link
Contributor Author

Also tbc whether the scatter plots here are replaced with a more lightweight version that doesn't create a billion JavaFX nodes, or whether we just subsample the points for display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant