Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polish language to the website #2120

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

BilalHassona
Copy link

@BilalHassona BilalHassona commented Mar 24, 2024

Summary

Assalamu alaykum, this PR adds Polish language to the website. I am native Polish speaker and fluent in English (Level C1/C2). The PR is ready to be merged and should work without any issues with few small caveats:

  1. There are some legal notices in locales/pl/privacy.json – I did my best to translate everything correctly and according to commonly used legal phrases, but I cannot guarantee that everything is translated correctly.
  2. I was not able to log in from localhost environment so I was not able to check if everything is translated correctly in context. I plan to do so after a release and create a follow up PR with some minor updates if needed. If there is a way to log in locally I could test and correct the translations in this PR.
  3. In src/styles/global.scss I slightly improved font display for special Polish characters such as: "ą", "ę", "ć", "ś" etc. They looked really bad (image 5) and now they look tolerably for normal texts (image 6) and quite bad (image 6) for bold texts.

My methodology was: translate as closely as possible to the originial (English) text – including punctuation. If not possible I would change the text as much as needed so that it made sens in Polish – and preserve the intended meaning. I see that special characters in French don't look great as well, so please let me know if I should search for a better font (and potentially add it to the project). For now I just improved Polish special characters with the existing fonts.

I added the Polish language above "Português" on the dropdown as per @Saidamir-Sh request (image 2).

Further contribution (not related to this PR)

I would love to contribute more (and I don't want any financial compensation) namely:

  1. Polish transliteration (written by Musa Czachorowski). I have .pdf file, but I can deliver it in any format that you accept. I can also add it myself if I know the programming language well enough, but I don't know in which repository it is stored in. Is it "Quran.com API"? Do I need an access to the database?
  2. Second Polish translation (written by Musa Czachorowski). Same situation as with point 1.
  3. Translating some other Apps if you have them

Please let me know if those contributions are needed and if they will accepted and if yes, then please help me find the needed answers. You can respond here or via Discord: my username: "0_.b.h._0" or any other way – I will adjust to you.

Test Plan

Run the App locally and change the translation (top-right corner with "globe" icon) to "Polski" – check if everything works and looks correctly.

Screenshots

Before After
image image
------ ------
image image
------ ------
image image

Copy link

vercel bot commented Mar 24, 2024

@BilalHassona is attempting to deploy a commit to the Quran Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quran-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 7:53pm

@mrgithub
Copy link

mrgithub commented Apr 7, 2024

This is excellent. We need this polish translation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants