This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Convert Smartbanner to styled-components #1020
Labels
Comments
I can take this. |
@atalebagha please do! I will merge this soon: #1005 Then can open it up for everyone to help out. Still a few missing items that I need to do after I merge it inshallah |
Is this still open ? |
@bahaa96 Yep! |
The SmartBanner file is over 500 lines now do you prefer to move the styled components to a separate file ? |
Yes! Separation is always preferable :) |
@mmahalwy Is this still open? If yes then can I pick it? |
@mmahalwy Can you guide me what changes are needed? |
@bahaa96 did you finish working on this? |
@mmahalwy Just wondering this issue is still open? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I'm submitting a ...
Current behavior:
The Smartbanner component is heavily using CSS and should instead use
styled-components
Expected / new behavior:
Convert to styled-components please!
The text was updated successfully, but these errors were encountered: