Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Convert Smartbanner to styled-components #1020

Open
1 of 3 tasks
mmahalwy opened this issue Aug 29, 2018 · 10 comments
Open
1 of 3 tasks

Convert Smartbanner to styled-components #1020

mmahalwy opened this issue Aug 29, 2018 · 10 comments

Comments

@mmahalwy
Copy link
Contributor

I'm submitting a ...

  • bug report
  • feature request
  • other

Current behavior:
The Smartbanner component is heavily using CSS and should instead use styled-components

Expected / new behavior:
Convert to styled-components please!

@atalebagha
Copy link
Contributor

I can take this.

@mmahalwy
Copy link
Contributor Author

@atalebagha please do! I will merge this soon: #1005

Then can open it up for everyone to help out. Still a few missing items that I need to do after I merge it inshallah

@bahaa96
Copy link
Contributor

bahaa96 commented Sep 13, 2018

Is this still open ?

@mmahalwy
Copy link
Contributor Author

@bahaa96 Yep!

@bahaa96
Copy link
Contributor

bahaa96 commented Sep 14, 2018

The SmartBanner file is over 500 lines now do you prefer to move the styled components to a separate file ?

@mmahalwy
Copy link
Contributor Author

Yes! Separation is always preferable :)

@atiqueansari1987
Copy link

@mmahalwy Is this still open? If yes then can I pick it?

@atiqueansari1987
Copy link

@mmahalwy Can you guide me what changes are needed?

@fatmali
Copy link

fatmali commented Jul 28, 2019

@bahaa96 did you finish working on this?

@kaiyum2012
Copy link

@mmahalwy Just wondering this issue is still open?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants