Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single scatter #143

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Conversation

pearsomark
Copy link

Following my question in the discussion group, this change creates a zero filled array for the upper scatter window to be passed to compute_TEW.
I don't know if *width_peak / 2 in compute_TEW is still valid in this case.

changed: src/pytomography/io/SPECT/dicom.py
ref: Scatter estimation using 2 energy windows

lukepolson and others added 3 commits March 1, 2024 08:30
Allow get_scatter_from_TEW() to use a single scatter window
@lukepolson
Copy link
Collaborator

@pearsomark thank you for this!! I think, to avoid confusion, we should probably just create a new function compute_scatter_from_DEW which only takes in a index_lower argument. I'd be happy to add myself, but would be cool to have you as a contributor if you wanted to submit like you did with this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants