Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11 colors #13

Merged
merged 7 commits into from
Mar 2, 2021
Merged

11 colors #13

merged 7 commits into from
Mar 2, 2021

Conversation

awtkns
Copy link
Contributor

@awtkns awtkns commented Mar 2, 2021 •
edited
Loading

closes #11

  • Add support for hex colors,
  • Defaults to MIM color palleted instead of random colors
  • Color Validation Enhancements

awtkns
awtkns commented Mar 2, 2021
View reviewed changes
rt_utils/utils.py Outdated Show resolved Hide resolved
@awtkns awtkns removed the request for review from carluri March 2, 2021 01:53
asim-shrestha
asim-shrestha reviewed Mar 2, 2021
View reviewed changes
rt_utils/utils.py Outdated Show resolved Hide resolved
asim-shrestha
asim-shrestha reviewed Mar 2, 2021
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
awtkns
awtkns commented Mar 2, 2021
View reviewed changes
rt_utils/utils.py Outdated Show resolved Hide resolved
awtkns
awtkns commented Mar 2, 2021
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
asim-shrestha
asim-shrestha reviewed Mar 2, 2021
View reviewed changes
rt_utils/utils.py

def validate_color(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to change but we should try to keep methods a tad smaller

awtkns
awtkns commented Mar 2, 2021
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@awtkns @asim-shrestha
Apply suggestions from code review
2330dc3 
Co-authored-by: Asim Shrestha <50181239+asim-shrestha@users.noreply.github.com>
awtkns
awtkns commented Mar 2, 2021
View reviewed changes
tests/test_utils.py Outdated Show resolved Hide resolved
@awtkns awtkns merged commit 20a27c4 into main Mar 2, 2021
@awtkns awtkns deleted the 11_colors branch March 21, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asim-shrestha asim-shrestha asim-shrestha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Hex Colors
2 participants
@awtkns @asim-shrestha