Skip to content

Commit

Permalink
Fix QIODevice warnings when closing tabs.
Browse files Browse the repository at this point in the history
This is a regression introduced in 43c9d69.
Fixes #517.
  • Loading branch information
The-Compiler committed Mar 18, 2015
1 parent 7dbdc1b commit 0d1f4c0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion qutebrowser/browser/webview.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,13 +303,13 @@ def _mousepress_opentarget(self, e):
def shutdown(self):
"""Shut down the webview."""
self.shutting_down.emit()
self.page().shutdown()
# We disable javascript because that prevents some segfaults when
# quitting it seems.
log.destroy.debug("Shutting down {!r}.".format(self))
settings = self.settings()
settings.setAttribute(QWebSettings.JavascriptEnabled, False)
self.stop()
self.page().shutdown()

def openurl(self, url):
"""Open a URL in the browser.
Expand Down

0 comments on commit 0d1f4c0

Please sign in to comment.